Re: [PATCH] cpufreq: pmac32: Use of_property_read_reg() to parse "reg"

From: Viresh Kumar
Date: Sun Jul 02 2023 - 23:02:01 EST


On 09-06-23, 12:31, Rob Herring wrote:
> Use the recently added of_property_read_reg() helper to get the
> untranslated "reg" address value.
>
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
> drivers/cpufreq/pmac32-cpufreq.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/cpufreq/pmac32-cpufreq.c b/drivers/cpufreq/pmac32-cpufreq.c
> index ec75e79659ac..f53635ba16c1 100644
> --- a/drivers/cpufreq/pmac32-cpufreq.c
> +++ b/drivers/cpufreq/pmac32-cpufreq.c
> @@ -378,10 +378,9 @@ static int pmac_cpufreq_cpu_init(struct cpufreq_policy *policy)
>
> static u32 read_gpio(struct device_node *np)
> {
> - const u32 *reg = of_get_property(np, "reg", NULL);
> - u32 offset;
> + u64 offset;
>
> - if (reg == NULL)
> + if (of_property_read_reg(np, 0, &offset, NULL) < 0)
> return 0;
> /* That works for all keylargos but shall be fixed properly
> * some day... The problem is that it seems we can't rely

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

--
viresh