Re: [PATCH 6.4 00/28] 6.4.1-rc1 review - hppa argument list too long

From: Helge Deller
Date: Sun Jul 02 2023 - 17:33:26 EST


Hi Linus,

On 6/30/23 08:56, Helge Deller wrote:
On 6/30/23 08:29, Greg Kroah-Hartman wrote:
On Thu, Jun 29, 2023 at 11:16:21PM -0700, Linus Torvalds wrote:
On Thu, 29 Jun 2023 at 22:31, Naresh Kamboju <naresh.kamboju@xxxxxxxxxx> wrote:

arch/parisc/mm/fault.c: In function 'do_page_fault':
arch/parisc/mm/fault.c:292:22: error: 'prev' undeclared (first use in this function)
   292 |                 if (!prev || !(prev->vm_flags & VM_GROWSUP))

Bah. "prev" should be "prev_vma" here.

I've pushed out the fix. Greg, apologies. It's

    ea3f8272876f parisc: fix expand_stack() conversion

and Naresh already pointed to the similarly silly sparc32 fix.

Ah, I saw it hit your repo before your email here, sorry about that.
Now picked up.

I've just cherry-picked ea3f8272876f on top of -rc2, built and run-tested it,
and everything is OK on parisc.

Actually, your changes seems to trigger...:

root@debian:~# /usr/bin/ls /usr/bin/*
-bash: /usr/bin/ls: Argument list too long

or with a long gcc argument list:
gcc: fatal error: cannot execute '/usr/lib/gcc/hppa-linux-gnu/12/cc1': execv: Argument list too long

I'm trying to understand what's missing, but maybe you have some idea?

Helge