Re: [PATCH v9 08/10] arm64: dts: qcom: sc8280xp: Add multiport controller node for SC8280

[Krishna Kurapati PSSNV]

On 6/27/2023 8:46 PM, Johan Hovold wrote:
> On Sat, Jun 24, 2023 at 12:43:23PM +0530, Krishna Kurapati PSSNV wrote:
> > > On 21.06.2023 06:36, Krishna Kurapati wrote:
> > > > Add USB and DWC3 node for tertiary port of SC8280 along with multiport
> > > > IRQ's and phy's. This will be used as a base for SA8295P and SA8295-Ride
> > > > platforms.
> > > >
> > > > Signed-off-by: Krishna Kurapati <quic_kriskura@xxxxxxxxxxx>
>
> > > Not a comment to the patch, but very nice that Qcom ensured every
> > > endpoint is wakeup-capable, this used not to be the case before :D
>
> > Yes wakeup is supported by all ports now, but I didn't make those
> > changes now as I wanted to keep driver code diff minimal and don't need
> > wakeup support for the product currently. But for sure, will update
> > driver code to handle wakeup on all ports in near future.
>
> Why didn't you include it in v9? I thought you had a working
> implementation for this?
>
> Since wakeup will be another case where glue and core need to interact,
> it's good to have the wakeup implementation from the start to be able to
> evaluate your multiport implementation properly.
>
> Right now it looks like you only added wakeup interrupt lookup and
> request, but then you never actually enable them which is not very nice.
>
> Johan

Hi Johan,

 As mentioned in one of my comments on earlier patches, wakeup is not a 
requirement I currently need to work on for the product. I added 
multiport IRQ support only because my pathces need to modify IRQ names. 
If there is a customer requirement I get in the future, I will 
definitely implement the wakeup part. But for now, I would like to stick 
to what is necessary for getting Multiport to work.

Regards,
Krishna,