Re: [PATCH v2 2/4] media: platform: mediatek: isp_30: add mediatek ISP3.0 sensor interface

[Chun-Kuang Hu]

Hi, Julien:

Chun-Kuang Hu <chunkuang.hu@xxxxxxxxxx> 於 2023年7月2日 週日 上午7:35寫道：
>
> Hi, Julien:
>
> Julien Stephan <jstephan@xxxxxxxxxxxx> 於 2023年6月30日 週五 下午6:05寫道：
> >
> > From: Louis Kuo <louis.kuo@xxxxxxxxxxxx>
> >
> > This will add the mediatek ISP3.0 seninf (sensor interface) driver found
> > on several Mediatek SoCs such as the mt8365.
> >
> > Then seninf module has 4 physical CSI-2 inputs. Depending on the soc they
> > may not be all connected.
> >
> > Signed-off-by: Louis Kuo <louis.kuo@xxxxxxxxxxxx>
> > Signed-off-by: Phi-bang Nguyen <pnguyen@xxxxxxxxxxxx>
> > Signed-off-by: Florian Sylvestre <fsylvestre@xxxxxxxxxxxx>
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Julien Stephan <jstephan@xxxxxxxxxxxx>
> >
>
> [snip]
>
> > +
> > +static const struct mtk_seninf_conf seninf_8365_conf = {
> > +       .model = "mtk-camsys-3.0",
> > +       .nb_inputs = 4,
> > +       .nb_muxes = 6,
> > +       .nb_outputs = 4,
> > +};
> > +
> > +static const struct of_device_id mtk_seninf_of_match[] = {
> > +       {
> > +               .compatible = "mediatek,mt8365-seninf",
> > +               .data = &seninf_8365_conf,
>
> Now only support one SoC, so it's necessary to select the SoC data and
> you could directly place the data in the code. After support other

Typo.

Now only support one SoC, so it's not necessary to select the SoC data
and you could directly place the data in the code.

Regards,
Chun-Kuang.

> SoC, so we could know what should be placed in struct mtg_seninf_conf
> (Now we have no any information).
>
> Regards,
> Chun-Kuang.
>
> > +       },
> > +       {
> > +       },
> > +};
> > +MODULE_DEVICE_TABLE(of, mtk_seninf_of_match);