Re: [PATCH 2/2] RISC-V: alternative: Remove feature_probe_func

From: Evan Green
Date: Fri Jun 30 2023 - 17:58:21 EST


On Mon, Jun 26, 2023 at 6:07 AM Conor Dooley <conor.dooley@xxxxxxxxxxxxx> wrote:
>
> Hey Evan,
>
> On Fri, Jun 23, 2023 at 03:20:16PM -0700, Evan Green wrote:
> > Now that we're testing unaligned memory copy and making that
> > determination generically, there are no more users of the vendor
> > feature_probe_func(). While I think it's probably going to need to come
> > back, there are no users right now, so let's remove it until it's
> > needed.
>
> How come this is done as a separate patch, rather than delete the dead
> code as part of the probe addition? Ease of review?

Yes, it just seemed like a logically distinct change. Thanks for the review!
-Evan