Re: [PATCH 0/2] mm: remove page_rmapping()

From: Matthew Wilcox
Date: Fri Jun 30 2023 - 17:39:43 EST


On Fri, Jun 30, 2023 at 08:13:08PM +0800, Peng Zhang wrote:
> From: ZhangPeng <zhangpeng362@xxxxxxxxxx>
>
> This minor patch series remove page_rmapping() and convert the last user
> fault_dirty_shared_page() to use a folio.

This patch series works better if you do it in the other order.
First convert the user, then remove the now-unused page_rmapping().

It's almost always a mistake to start with "I want to remove all the
users of API x". You should be thinking "Here is function y that still
uses pages; I shall convert it to use folios".