Re: [PATCH RFC v4 1/7] drm: Introduce solid fill DRM plane property

From: Jessica Zhang
Date: Fri Jun 30 2023 - 13:55:28 EST




On 6/30/2023 3:33 AM, Dmitry Baryshkov wrote:
On 30/06/2023 03:25, Jessica Zhang wrote:
Document and add support for solid_fill property to drm_plane. In
addition, add support for setting and getting the values for solid_fill.

To enable solid fill planes, userspace must assign a property blob to
the "solid_fill" plane property containing the following information:

struct drm_solid_fill_info {
    u8 version;
    u32 r, g, b;
};

Signed-off-by: Jessica Zhang <quic_jesszhan@xxxxxxxxxxx>
---
  drivers/gpu/drm/drm_atomic_state_helper.c |  9 +++++
  drivers/gpu/drm/drm_atomic_uapi.c         | 55 +++++++++++++++++++++++++++++++
  drivers/gpu/drm/drm_blend.c               | 33 +++++++++++++++++++
  include/drm/drm_blend.h                   |  1 +
  include/drm/drm_plane.h                   | 43 ++++++++++++++++++++++++
  5 files changed, 141 insertions(+)

Also, I think the point which we missed up to now. Could you please add both new properties to dri/N/state debugfs?

Hi Dmitry,

Good catch -- acked.

Thanks,

Jessica Zhang


--
With best wishes
Dmitry