Re: [v2 01/13] perf parse-events: Remove unused PE_PMU_EVENT_FAKE token

From: Ian Rogers
Date: Fri Jun 30 2023 - 13:34:52 EST


On Fri, Jun 30, 2023 at 10:23 AM Markus Elfring <Markus.Elfring@xxxxxx> wrote:
>
> >>>>> Removed by commit 70c90e4a6b2f ("perf parse-events: Avoid scanning
> >>>>> PMUs before parsing").
> >>>>
> >>>> Will the chances ever grow to add another imperative change suggestion?
> >>>>
> >>>> See also:
> >>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n94
> >>>
> >>>
> >>> Sorry, I can't parse this.
> >>
> >> Can you take the requirement “Describe your changes in imperative mood”
> >> into account for any more descriptions?
> >
> > Yep, still doesn't parse.
>
> Does this feedback really indicate that you stumble still on understanding difficulties
> for the linked development documentation?
>
> Can the mentioned patch review concern be adjusted with wording alternatives
> for improved commit messages?

Sorry, checked with a colleague and kernel contributor, we don't know
what is being requested here, "imperative mood" makes no sense, as
such I don't have a fix for what you're requesting.

Thanks,
Ian

> Regards,
> Markus