Re: [PATCH v2 2/2] dt-bindings: leds: Read max-brightness from devicetree

From: Rob Herring
Date: Fri Jun 30 2023 - 12:49:36 EST


On Fri, Jun 30, 2023 at 11:22:47AM +0200, Astrid Rost wrote:
> Add max-brightness in order to reduce the current on the connected LEDs.
> Normally, the maximum brightness is determined by the hardware, and this
> property is not required. This property is used to set a software limit.
> It could happen that an LED is made so bright that it gets damaged or
> causes damage due to restrictions in a specific system, such as mounting
> conditions. Note that led-max-microamp should be preferably used, if it
> is supported by the controller.
>
> Signed-off-by: Astrid Rost <astrid.rost@xxxxxxxx>
> ---
> Documentation/devicetree/bindings/leds/common.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)

The patch order is wrong. You have to define a property before you can
use it. Otherwise,

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>