RE: [PATCH] ACPI: resource: Add IRQ override for MECHREV Jiaolong17KS

From: Limonciello, Mario
Date: Fri Jun 30 2023 - 09:10:08 EST


[Public]

> -----Original Message-----
> From: Linux regression tracking (Thorsten Leemhuis)
> <regressions@xxxxxxxxxxxxx>
> Sent: Friday, June 30, 2023 8:06 AM
> To: Li Chen <me@linux.beauty>; linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>;
> linux-acpi <linux-acpi@xxxxxxxxxxxxxxx>; Len Brown <lenb@xxxxxxxxxx>; Rafael
> J. Wysocki <rafael@xxxxxxxxxx>; Limonciello, Mario
> <Mario.Limonciello@xxxxxxx>
> Cc: Linux kernel regressions list <regressions@xxxxxxxxxxxxxxx>
> Subject: Re: [PATCH] ACPI: resource: Add IRQ override for MECHREV
> Jiaolong17KS
>
> [CCing mario and the regressions list]
>
> On 30.06.23 14:20, Li Chen wrote:
> > Fix a regression introduced by commit 9946e39fe8d0 ("ACPI: resource: skip
> > IRQ override on AMD Zen platforms") on MECHREV Jiaolong17KS, which
> > causes the built-in keyboard to not work. This restores the functionality
> > by adding an IRQ override.
> >
> > I have personally tested this on the 17" model but I'm not sure if this
> > issue is present on the 16 model.
> >
> > Fixes: 9946e39fe8d0 ("ACPI: resource: skip IRQ override on AMD Zen
> platforms")
> > Signed-off-by: Li Chen <me@linux.beauty>
>
> Not my area of expertise (so take this with a gain of salt), but I'm
> aware of something that afaics concerns this:
>
> A few days ago a patch was merged to mainline that afaics hopefully
> might make a change like your unnecessary. See a9c4a912b7d ("ACPI:
> resource: Remove "Zen" specific match and quirks") in mainline or here:
> https://lore.kernel.org/all/20230601221151.670-1-
> mario.limonciello@xxxxxxx/
>
> Might be worth giving a try.
>
> There is a rough plan to backport this to stable kernels, unless
> problems show up.

Correct.