Re: [PATCH 6.4 00/28] 6.4.1-rc1 review

From: Guenter Roeck
Date: Fri Jun 30 2023 - 02:33:53 EST


On 6/29/23 23:29, Guenter Roeck wrote:
On 6/29/23 23:16, Linus Torvalds wrote:
On Thu, 29 Jun 2023 at 22:31, Naresh Kamboju <naresh.kamboju@xxxxxxxxxx> wrote:

arch/parisc/mm/fault.c: In function 'do_page_fault':
arch/parisc/mm/fault.c:292:22: error: 'prev' undeclared (first use in this function)
   292 |                 if (!prev || !(prev->vm_flags & VM_GROWSUP))

Bah. "prev" should be "prev_vma" here.

I've pushed out the fix. Greg, apologies. It's

    ea3f8272876f parisc: fix expand_stack() conversion

and Naresh already pointed to the similarly silly sparc32 fix.

              Linus

Did you see that one (in mainline) ?

Building csky:defconfig ... failed
--------------
Error log:
arch/csky/mm/fault.c: In function 'do_page_fault':
arch/csky/mm/fault.c:240:40: error: 'address' undeclared (first use in this function); did you mean 'addr'?
  240 |         vma = lock_mm_and_find_vma(mm, address, regs);


This is also in {6.1,6.3,6.4}-rc unless I am missing something.

Guenter