Re: [PATCH 1/4] pcie: qcom: Fix the macro PARF_SLV_ADDR_SPACE_SIZE_2_3_3

[Sricharan Ramabadhran]

Hi Bjorn,

On 6/23/2023 11:30 PM, Bjorn Helgaas wrote:
> On Fri, Jun 23, 2023 at 03:04:42PM +0530, Sricharan Ramabadhran wrote:
> > PARF_SLV_ADDR_SPACE_SIZE_2_3_3 macro used for IPQ8074
> > pcie slave addr size was initially set to 0x358, but
> > was wrongly changed to 0x168 as a part of
> > 'PCI: qcom: Sort and group registers and bitfield definitions'
> > Fixing it back to right value here.
>
> 1) Make your subject line match the history.  For example, you're
> fixing 769e49d87b15 ("PCI: qcom: Sort and group registers ..."), so
> your subject line should start with "PCI: qcom: ...".

 ok, will fix.

> 2) It doesn't look like 769e49d87b15 changed
> PARF_SLV_ADDR_SPACE_SIZE_2_3_3:
>
>    $ git show 769e49d87b15 | grep PARF_SLV_ADDR_SPACE_SIZE_2_3_3
>    +#define PARF_SLV_ADDR_SPACE_SIZE_2_3_3		0x16C /* Register offset specific to IP ver 2.3.3 */
>    -#define PARF_SLV_ADDR_SPACE_SIZE_2_3_3		0x16C /* Register offset specific to IP rev 2.3.3 */
>
> What am I missing here?  Do you have another out-of-tree patch that
> broke this?

 39171b33f652 ("PCI: qcom: Remove PCIE20_ prefix from
               register definitions") broke it. Will change and post .

Regards,
 Sricharan