Re: [PATCH v1 1/5] ASoC: dt-bindings: Add StarFive JH7110 dummy PWM-DAC transmitter

From: Hal Feng
Date: Thu Jun 29 2023 - 21:57:12 EST


On Mon, 26 Jun 2023 17:34:56 +0200, Krzysztof Kozlowski wrote:
> On 26/06/2023 13:09, Hal Feng wrote:
>> Add bindings for StarFive JH7110 dummy PWM-DAC transmitter.
>
> ...
>
>> +required:
>> + - compatible
>> + - "#sound-dai-cells"
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + pwmdac-dit {
>> + compatible = "starfive,jh7110-pwmdac-dit";
>> + #sound-dai-cells = <0>;
>
> BTW, I don't see any resources here. Neither in the driver. I think you
> just added this for driver, not for a real hardware.

Yes, this is a dummy PWM-DAC transmitter as described in the title. The
StarFive JH7110 PWM-DAC module doesn't need a hardware codec, but a
dummy codec is needed for the driver.

For a similar implementation, you can refer to
sound/soc/codecs/spdif_transmitter.c

Best regards,
Hal