Re: [PATCH] sysctl: fix unused proc_cap_handler() function warning

[Matthieu Baerts]

Hi Arnd,

On 07/06/2023 14:08, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
> 
> Since usermodehelper_table() is marked static now, we get a
> warning about it being unused when SYSCTL is disabled:
> 
> kernel/umh.c:497:12: error: 'proc_cap_handler' defined but not used [-Werror=unused-function]

Thank you for the patch!

We also hit the same issue on our side after today's sync with Linus'
tree. I confirm this patch fixes the issue.

Tested-by: Matthieu Baerts <matthieu.baerts@xxxxxxxxxxxx>

I didn't see this patch applied in Luis' sysctl-next branch, do you know
who is taking care of it?

> Just move it inside of the same #ifdef.
> 
> Fixes: e6944e3b75df7 ("sysctl: move umh sysctl registration to its own file")

A small detail: it looks like the SHA has been modified, it should be
861dc0b46432 instead of e6944e3b75df7:

Fixes: 861dc0b46432 ("sysctl: move umh sysctl registration to its own file")

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net