Re: [PATCH] ASoC: core: Always store of_node when getting DAI link component

[Mark Brown]

On Mon, Jun 26, 2023 at 12:49:16PM +0100, Mark Brown wrote:
> On Sun, Jun 25, 2023 at 11:54:29PM +0000, Kuninori Morimoto wrote:
> 
> > > The generic snd_soc_dai_get_dlc() contains a default translation function
> > > for DAI names which has factored out common code in a number of card
> > > drivers, resolving the dai_name and of_node either using a driver provided
> 
> > Yes, indeed.
> > But I think we want to set it under lock and if ret was no error case ?
> 
> It doesn't really matter - there's only one possible result, and nothing
> should be looking at the dlc unless we return success, but yes that'd
> probably be a little cleaner providing we don't ever return early.

BTW that's not to say don't submit this as a patch, just that it doesn't
need to get applied as a fix.

Attachment: signature.asc
Description: PGP signature