arch/riscv/include/asm/atomic.h:317 arch_atomic_dec_if_positive() warn: inconsistent indenting
From: kernel test robot
Date: Thu Jun 29 2023 - 09:16:00 EST
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 3a8a670eeeaa40d87bd38a587438952741980c18
commit: 1d7f6932c522ea95668e14265175ce3d753d0c24 riscv: atomic: Optimize dec_if_positive functions
date: 1 year, 1 month ago
config: riscv-randconfig-m031-20230629 (https://download.01.org/0day-ci/archive/20230629/202306292044.M7rvGInB-lkp@xxxxxxxxx/config)
compiler: riscv64-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230629/202306292044.M7rvGInB-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306292044.M7rvGInB-lkp@xxxxxxxxx/
smatch warnings:
arch/riscv/include/asm/atomic.h:317 arch_atomic_dec_if_positive() warn: inconsistent indenting
vim +317 arch/riscv/include/asm/atomic.h
fab957c11efe2f Palmer Dabbelt 2017-07-10 312
1d7f6932c522ea Guo Ren 2022-05-05 313 static __always_inline int arch_atomic_dec_if_positive(atomic_t *v)
fab957c11efe2f Palmer Dabbelt 2017-07-10 314 {
fab957c11efe2f Palmer Dabbelt 2017-07-10 315 int prev, rc;
fab957c11efe2f Palmer Dabbelt 2017-07-10 316
fab957c11efe2f Palmer Dabbelt 2017-07-10 @317 __asm__ __volatile__ (
5ce6c1f3535fa8 Andrea Parri 2018-03-09 318 "0: lr.w %[p], %[c]\n"
1d7f6932c522ea Guo Ren 2022-05-05 319 " addi %[rc], %[p], -1\n"
5ce6c1f3535fa8 Andrea Parri 2018-03-09 320 " bltz %[rc], 1f\n"
5ce6c1f3535fa8 Andrea Parri 2018-03-09 321 " sc.w.rl %[rc], %[rc], %[c]\n"
5ce6c1f3535fa8 Andrea Parri 2018-03-09 322 " bnez %[rc], 0b\n"
5ce6c1f3535fa8 Andrea Parri 2018-03-09 323 " fence rw, rw\n"
5ce6c1f3535fa8 Andrea Parri 2018-03-09 324 "1:\n"
fab957c11efe2f Palmer Dabbelt 2017-07-10 325 : [p]"=&r" (prev), [rc]"=&r" (rc), [c]"+A" (v->counter)
1d7f6932c522ea Guo Ren 2022-05-05 326 :
fab957c11efe2f Palmer Dabbelt 2017-07-10 327 : "memory");
1d7f6932c522ea Guo Ren 2022-05-05 328 return prev - 1;
fab957c11efe2f Palmer Dabbelt 2017-07-10 329 }
fab957c11efe2f Palmer Dabbelt 2017-07-10 330
:::::: The code at line 317 was first introduced by commit
:::::: fab957c11efe2f405e08b9f0d080524bc2631428 RISC-V: Atomic and Locking Code
:::::: TO: Palmer Dabbelt <palmer@xxxxxxxxxxx>
:::::: CC: Palmer Dabbelt <palmer@xxxxxxxxxxx>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki