Re: [PATCH v2] serial: 8250: Preserve original value of DLF register

From: Andy Shevchenko
Date: Thu Jun 29 2023 - 09:13:51 EST


On Thu, Jun 29, 2023 at 08:35:30PM +0800, Ruihong Luo wrote:
> This commit is aimed at preserving the original value of the

Preserve the original value...

> DLF(Divisor Latch Fraction Register). When the DLF register is

Divisor Latch Fraction (DLF) register...

> modified without preservation, it can disrupt the baudrate settings
> established by firmware or bootloader , leading to data corruption

...bootloader, leading...

> and the generation of unreadable or distorted characters.

> Fixes: 701c5e73b296 ("serial: 8250_dw: add fractional divisor support")
> Signed-off-by: Ruihong Luo <luoruihong@xxxxxxxxxx>
> ---
> v2:
> - add a tag

It's a v3 and still some comments are not (yet) addressed:
1) your from header in email != SoB;
2) do not use In-reply-to email header for the new patch versions;
3) the commit message should be amended as I pointed out above again.

It will go nowhere if you continue ignoring reviewers' comments.

--
With Best Regards,
Andy Shevchenko