Re: [PATCH v2 7/7] quota: remove unused function put_dquot_list()

From: Baokun Li
Date: Thu Jun 29 2023 - 08:18:33 EST


On 2023/6/29 19:05, Jan Kara wrote:
On Wed 28-06-23 21:21:55, Baokun Li wrote:
Now that no one is calling put_dquot_list(), remove it.

Signed-off-by: Baokun Li <libaokun1@xxxxxxxxxx>
I guess you can merge this with patch 6. When there was only a single user,
there's no good reason to separate the removal of the unused function...

Honza
I got a warning when I compiled after I finished patch 6, and then there was
this patch. I will merge this patch into patch 6 in the next version.
---
fs/quota/dquot.c | 20 --------------------
1 file changed, 20 deletions(-)

diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
index df028fb2ce72..ba0125473be3 100644
--- a/fs/quota/dquot.c
+++ b/fs/quota/dquot.c
@@ -1102,26 +1102,6 @@ static void remove_inode_dquot_ref(struct inode *inode, int type)
dqput(dquot);
}
-/*
- * Free list of dquots
- * Dquots are removed from inodes and no new references can be got so we are
- * the only ones holding reference
- */
-static void put_dquot_list(struct list_head *tofree_head)
-{
- struct list_head *act_head;
- struct dquot *dquot;
-
- act_head = tofree_head->next;
- while (act_head != tofree_head) {
- dquot = list_entry(act_head, struct dquot, dq_free);
- act_head = act_head->next;
- /* Remove dquot from the list so we won't have problems... */
- list_del_init(&dquot->dq_free);
- dqput(dquot);
- }
-}
-
static void remove_dquot_ref(struct super_block *sb, int type)
{
struct inode *inode;
--
2.31.1

Thanks!
--
With Best Regards,
Baokun Li
.