Re: [PATCH v1 1/1] kasan: Replace strreplace() with strchrnul()

From: Andy Shevchenko
Date: Thu Jun 29 2023 - 05:22:56 EST


On Wed, Jun 28, 2023 at 05:39:26PM +0200, Alexander Potapenko wrote:
> On Wed, Jun 28, 2023 at 5:34 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

...

> > /* Strip line number; without filename it's not very helpful. */
> > - strreplace(token, ':', '\0');
> > + p[strchrnul(token, ':') - token] = '\0';
>
> Why not just
> *(strchrnul(token, ':')) = '\0';
> ?

I don't like Pythonish style in the C. But if you insist, I can update it.

--
With Best Regards,
Andy Shevchenko