Re: [PATCH v4 3/4] ublk: enable zoned storage support

From: Andreas Hindborg (Samsung)
Date: Thu Jun 29 2023 - 03:30:03 EST



Christoph Hellwig <hch@xxxxxxxxxxxxx> writes:

> What's the point in having a separate file for about 100 lines of
> actual code? Especially as that needs a header, intefaces, etc?

This was suggested by Niklas [1] to make the conditionally compiled code
more readable. The alternative would be masking out the code with a big
`#ifdef`.

If you prefer the latter, I can change it back, no problem. But I must
say I think it comes off cleaner when we move as much as possible of the
zoned code to a separate translation unit.

[1] https://lore.kernel.org/all/Y%2Fy+UFEHn1F1sg4i@x1-carbon/