Re: Build error in crypto/marvell/cesa/cipher.c

From: Kees Cook
Date: Wed Jun 28 2023 - 23:53:48 EST


On Wed, Jun 28, 2023 at 08:13:25PM -0700, Linus Torvalds wrote:
> I get a similar error in 'irdma_clr_wqes()' at
> drivers/infiniband/hw/irdma/uk.c:103 (and same thing on line 105). I
> don't see what the right solution there is, but it looks like we have
>
> IRDMA_CQP_WQE_SIZE = 8
> __le64 elem[IRDMA_CQP_WQE_SIZE];
>
> and it's doing a 4kB memset to that element. The mistake is not as
> obvious as in the cesa driver.

I pressed "send" too fast. :)

This should also already be fixed:
https://lore.kernel.org/all/20230523111859.2197825-1-arnd@xxxxxxxxxx/

--
Kees Cook