Re: [Freedreno] [PATCH 06/15] dt-bindings: display/msm: sc7180-dpu: Describe SM6125

From: Abhinav Kumar
Date: Wed Jun 28 2023 - 16:34:50 EST




On 6/26/2023 7:04 AM, Dmitry Baryshkov wrote:
On 24/06/2023 03:41, Marijn Suijten wrote:
SM6125 is identical to SM6375 except that while downstream also defines
a throttle clock, its presence results in timeouts whereas SM6375
requires it to not observe any timeouts.

I see that the vendor DTS still references this clock.

Abhinav, Tanya, do possibly know what can be wrong here?


From display side, we just enable it without any specific vote. Seeing timeouts without it makes sense but not with it.

I dont have experience with this family of chipsets and this clock is specific to this family of chipsets.

Will reach out to folks who might have a better idea about this clock and update with possible suggestions.

Unless ... tanya has more suggestions.


Signed-off-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>
---
  Documentation/devicetree/bindings/display/msm/qcom,sc7180-dpu.yaml | 1 +
  1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sc7180-dpu.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sc7180-dpu.yaml
index 630b11480496..6d2ba9a1cca1 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sc7180-dpu.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sc7180-dpu.yaml
@@ -15,6 +15,7 @@ properties:
    compatible:
      enum:
        - qcom,sc7180-dpu
+      - qcom,sm6125-dpu
        - qcom,sm6350-dpu
        - qcom,sm6375-dpu