Re: [PATCH] dt-bindings: timer: add Ralink SoCs system tick counter

From: Sergio Paracuellos
Date: Wed Jun 28 2023 - 12:43:09 EST


Hi Rob,

On Wed, Jun 28, 2023 at 5:40 PM Rob Herring <robh@xxxxxxxxxx> wrote:
>
> On Wed, Jun 28, 2023 at 10:27:16AM +0200, Sergio Paracuellos wrote:
> > Add YAML doc for the system tick counter which is present on Ralink SoCs.
> >
> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx>
> > ---
> > .../bindings/timer/ralink,cevt-systick.yaml | 38 +++++++++++++++++++
> > 1 file changed, 38 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/timer/ralink,cevt-systick.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/timer/ralink,cevt-systick.yaml b/Documentation/devicetree/bindings/timer/ralink,cevt-systick.yaml
> > new file mode 100644
> > index 000000000000..59d97feddf4e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/timer/ralink,cevt-systick.yaml
> > @@ -0,0 +1,38 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/timer/ralink,cevt-systick.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: System tick counter present in Ralink family SoCs
> > +
> > +maintainers:
> > + - Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx>
> > +
> > +properties:
> > + compatible:
> > + const: ralink,cevt-systick
>
> What is "cevt"? Would be nice to define. Really this should have been
> SoC specific, but it looks like it has been upstream "forever", so fine.

Not sure what cevt really means, I guess maybe "clock event"? Inside
the documentation this is just listed as "System Tick Counter". It is
upstreamed since Ralink SoCs are on tree. I am just documenting
already mainlined stuff since there are lots of missing binding docs
for old Ralink SoCs.

>
> Otherwise,
>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>

Thanks!

Best regards,
Sergio Paracuellos
>
> (the error report can be ignored)