Re: [PATCH v2] crypto: qat - Replace the if statement with min()

From: Andy Shevchenko
Date: Wed Jun 28 2023 - 06:47:58 EST


On Tue, Jun 27, 2023 at 03:17:24PM +0800, You Kangren wrote:
> Replace the if statement with min_t() to simplify the code

...

> - if (words_num < UWORD_CPYBUF_SIZE)
> - cpylen = words_num;
> - else
> - cpylen = UWORD_CPYBUF_SIZE;
> + cpylen = min_t(unsigned int, words_num, UWORD_CPYBUF_SIZE);

min_t() can be dangerous some times.

To make it robust I would suggest to use min() and mark UWORD_CPYBUF_SIZE
with U suffix to make the type the same.

--
With Best Regards,
Andy Shevchenko