RE: [PATCH V2] ptp: clockmatrix: Add Defer probe if firmware load fails

From: Gaddam, Sarath Babu Naidu
Date: Wed Jun 28 2023 - 03:57:55 EST




> -----Original Message-----
> From: Jakub Kicinski <kuba@xxxxxxxxxx>
> Sent: Friday, June 16, 2023 1:35 AM
> To: Gaddam, Sarath Babu Naidu <sarath.babu.naidu.gaddam@xxxxxxx>
> Cc: richardcochran@xxxxxxxxx; netdev@xxxxxxxxxxxxxxx;
> simon.horman@xxxxxxxxxxxx; andrew@xxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; vincent.cheng.xh@xxxxxxxxxxx; Katakam, Harini
> <harini.katakam@xxxxxxx>; git (AMD-Xilinx) <git@xxxxxxx>
> Subject: Re: [PATCH V2] ptp: clockmatrix: Add Defer probe if firmware
> load fails
>
> On Wed, 14 Jun 2023 10:42:04 +0530 Sarath Babu Naidu Gaddam wrote:
> > Clock matrix driver can be probed before the rootfs containing
> > firmware/initialization .bin is available. The current driver throws a
> > warning and proceeds to execute probe even when firmware is not
> ready.
> > Instead, defer probe and wait for the .bin file to be available.
>
> The first-step fix should be to try to get the FW into initramfs.
> For that driver should specify MODULE_FIRMWARE(), which I don't see
> here.

Thanks for the review. We will take MODULE_FIRMWARE as a separate patch.
We want defer probe to go first.

Thanks,
Sarath