Re: [PATCH] fs: iomap: Change the type of blocksize from 'int' to 'unsigned int' in iomap_file_buffered_write_punch_delalloc

[Chaitanya Kulkarni]

On 6/27/23 03:03, Lu Hongfei wrote:
> The return value type of i_blocksize() is 'unsigned int', so the
> type of blocksize has been modified from 'int' to 'unsigned int'
> to ensure data type consistency.
>
> Signed-off-by: Lu Hongfei <luhongfei@xxxxxxxx>
> ---
>   fs/iomap/buffered-io.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
> index a4fa81af60d9..90ea9e09c1ae 100644
> --- a/fs/iomap/buffered-io.c
> +++ b/fs/iomap/buffered-io.c
> @@ -1076,7 +1076,7 @@ int iomap_file_buffered_write_punch_delalloc(struct inode *inode,
>   {
>   	loff_t			start_byte;
>   	loff_t			end_byte;
> -	int			blocksize = i_blocksize(inode);
> +	unsigned int	blocksize = i_blocksize(inode);
>   
>   	if (iomap->type != IOMAP_DELALLOC)
>   		return 0;

Indeed as per include/linux/fs.h:
719 static inline unsigned int i_blocksize(const struct inode *node)

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx>

-ck