Re: [PATCH] perf test: Fix a compile error on pe-file-parsing.c

[Namhyung Kim]

On Tue, Jun 27, 2023 at 7:56 AM Ian Rogers <irogers@xxxxxxxxxx> wrote:
>
> On Mon, Jun 26, 2023 at 11:33 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> >
> > The dso__find_symbol_by_name() should be have idx pointer argument.
> > Found during the build-test.
> >
> >   $ make build-test
> >   ...
> >     CC      /tmp/tmp.6JwPK1xbWG/tests/pe-file-parsing.o
> >   tests/pe-file-parsing.c: In function ‘run_dir’:
> >   tests/pe-file-parsing.c:64:15: error: too few arguments to function ‘dso__find_symbol_by_name’
> >      64 |         sym = dso__find_symbol_by_name(dso, "main");
> >         |               ^~~~~~~~~~~~~~~~~~~~~~~~
> >   In file included from tests/pe-file-parsing.c:16:
> >   /usr/local/google/home/namhyung/project/linux/tools/perf/util/symbol.h:135:16: note: declared here
> >     135 | struct symbol *dso__find_symbol_by_name(struct dso *dso, const char *name, size_t *idx);
> >         |                ^~~~~~~~~~~~~~~~~~~~~~~~
> >
> > Fixes: 259dce914e93 ("perf symbol: Remove symbol_name_rb_node")
> > Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
>
> Acked-by: Ian Rogers <irogers@xxxxxxxxxx>

Applied to perf-tools-next, thanks!