Re: [PATCH 1/1] regmap: spi-avmm: Fix regmap_bus max_raw_write

From: Jim Wylder
Date: Tue Jun 27 2023 - 08:48:58 EST


On Tue, Jun 27, 2023 at 6:58 AM Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> On Tue, Jun 27, 2023 at 11:36:06AM +0800, Xu Yilun wrote:
>
> > I'm a bit prefer to exclude the reg addr, as it is in stable tree now
> > and doesn't see strong reason to change it. And suggest regmap-i2c does
> > the same as spi do, that is to reserve space for reg addr/padding by
> > reducing the max_raw_read/write value, see:
>
> It seems better to keep things like this in the core since every time a
> bus has to open code something that's something that the bus can get
> wrong, as we've seen here. This would mean some churn now but going
> forwards it'd be less error prone.

Agreed.