RE: [PATCH net] net: phy: mscc: fix packet loss due to RGMII delays

[Katakam, Harini]

> -----Original Message-----
> From: Vladimir Oltean <vladimir.oltean@xxxxxxx>
> Sent: Tuesday, June 27, 2023 2:41 PM
> To: netdev@xxxxxxxxxxxxxxx
> Cc: Jose Abreu <Jose.Abreu@xxxxxxxxxxxx>; Andrew Lunn
> <andrew@xxxxxxx>; Heiner Kallweit <hkallweit1@xxxxxxxxx>; Russell King
> <linux@xxxxxxxxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric
> Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo
> Abeni <pabeni@xxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; Katakam, Harini
> <harini.katakam@xxxxxxx>
> Subject: [PATCH net] net: phy: mscc: fix packet loss due to RGMII delays
> 
> Two deadly typos break RX and TX traffic on the VSC8502 PHY using RGMII
> if phy-mode = "rgmii-id" or "rgmii-txid", and no "tx-internal-delay-ps"
> override exists. The negative error code from phy_get_internal_delay()
> does not get overridden with the delay deduced from the phy-mode, and
> later gets committed to hardware. Also, the rx_delay gets overridden by
> what should have been the tx_delay.
> 
> Fixes: dbb050d2bfc8 ("phy: mscc: Add support for RGMII delay
> configuration")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>

Thanks
Reviewed-by: Harini Katakam <harini.katakam@xxxxxxx>

Regards,
Harini