Re: [PATCH 01/12] writeback: Factor out writeback_finish()

From: Christoph Hellwig
Date: Tue Jun 27 2023 - 00:05:30 EST


On Mon, Jun 26, 2023 at 06:35:10PM +0100, Matthew Wilcox (Oracle) wrote:
> + struct folio_batch fbatch;
> + pgoff_t done_index;
> + int err;
> +

I think this really needs a comment that it should only be used for
the writeback iterator. In fact this whole structure could use a lot
more comments on what should / can be set by the caller, and what is
internal.

> + unsigned range_whole:1; /* entire file */

Same here.