Re: [PATCH net-next] tools: Fix MSG_SPLICE_PAGES build error in trace tools

[Jakub Kicinski]

On Mon, 26 Jun 2023 14:31:39 -0700 Namhyung Kim wrote:
> Right, we want to keep the headers files in the tools in sync with
> the kernel ones.  And they are used to generate some tables.
> Full explanation from Arnaldo below.
> 
> So I'm ok for the msg_flags.c changes, but please refrain from
> changing the header directly.  We will update it later.
> 
> With that,
>   Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Ah, missed this email, sounds like this is preferred to Matthieu's
fix, we'll take this one.

> Also I wonder if the tool needs to keep the original flag
> (SENDPAGE_NOTLAST) for the older kernels.

That's a bit unclear, because it's just a kernel-internal flag.
Future kernels may well use that bit for something else.

Better long term solution would be to use an enum so that the values
are included in debuginfo and perf can read them at runtime :(