Re: [PATCH 1/7] dt-bindings: qcom: Allow SoC names ending in "pro"

From: Rob Herring
Date: Mon Jun 26 2023 - 17:27:33 EST


On Mon, Jun 26, 2023 at 10:00:23PM +0200, Konrad Dybcio wrote:
> There are a couple of SoCs whose names end in "pro", with the currently-
> upstream examples being msm8974pro and msm8996pro. Allow such suffix in
> SoC-specific compatibles.
>
> Fixes: 5aa332c5e7ca ("dt-bindings: qcom: document preferred compatible naming")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/arm/qcom-soc.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom-soc.yaml b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> index e333ec4a9c5f..607a1cf1ef94 100644
> --- a/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> @@ -31,7 +31,7 @@ properties:
> compatible:
> oneOf:
> # Preferred naming style for compatibles of SoC components:
> - - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|sa|sc|sdm|sdx|sm)[0-9]+-.*$"
> + - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|sa|sc|sdm|sdx|sm)[0-9]+(pro|)-.*$"

"(pro)?" would be slightly better than "(pro|)" IMO.

Acked-by: Rob Herring <robh@xxxxxxxxxx>

> - pattern: "^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$"
>
> # Legacy namings - variations of existing patterns/compatibles are OK,
>
> --
> 2.41.0
>