Re: [PATCH] time: ntp: Remove unnecessary ‘-ENODEV’ values from err

From: Thomas Gleixner
Date: Mon Jun 26 2023 - 16:53:34 EST


On Wed, Jun 28 2023 at 02:25, Li zeming wrote:
> err is assigned first, so it does not need to initialize the
> assignment.

I don't know how you or the broken tool you rely upon came to that
conclusion.

There is clearly an error exit path which proves you wrong.

Please look at your changes and compile them before posting. There are
existing tools which do a better job than that.

Thanks,

tglx