Re: [PATCH 5/5] scsi: dt-bindings: ufs: qcom: Fix warning for sdm845 by adding reg-names

From: Luca Weiss
Date: Mon Jun 26 2023 - 04:19:17 EST


On Mon Jun 26, 2023 at 9:41 AM CEST, Krzysztof Kozlowski wrote:
> On 26/06/2023 08:38, Luca Weiss wrote:
> >>>> but I guess no resends and it can be superseded.
> >>>
> >>> Right, the patches got reviews but was never applied... I really need to
> >>> find a strategy to keep track of sent patches until they're applied with
> >>> my work mailbox, it's not the first time that a patch has gotten
> >>> forgotten.
> >>
> >> There was an error reported on the above series. Why would it be
> >> applied?
> >
> > The error report at [0] complains about reg-names but I'm quite sure
> > that patch 2/3 resolves this error. Does your bot only apply one patch
> > at a time and run the check or apply all of them and then run it? It's
> > been a while but I'm fairly sure I ran all of the checks before sending
> > since I also documented some other patches in the cover letter there.
>
> You did it in cover letter, not in the patch, so there is no dependency
> for bots recorded.

I'm not aware how to put extra comments into a patch in a series with
b4, at least last time I checked I don't think it was possible? But I
also thought the cover letter was exactly there for giving some
background of the series and documenting any dependencies on other
patches.

>
> >
> > [0] https://lore.kernel.org/all/167241769341.1925758.17856681634949446114.robh@xxxxxxxxxx/
>
> Your patch 2/3 could not be applied to any tree. 3/3 applied but without
> previous one caused warnings.

Anyways, just resent the series as v4, maybe this time it can get picked
up... Should have enough reviews by now :)

Regards
Luca

>
>
>
>
> Best regards,
> Krzysztof