Re: [PATCH v2 1/2] ACPI: platform: Ignore SMB0001 only when it has resources

From: Andy Shevchenko
Date: Mon Jun 26 2023 - 04:15:32 EST


On Fri, Jun 23, 2023 at 04:43:55PM +0200, Rafael J. Wysocki wrote:
> On Thu, Jun 22, 2023 at 8:19 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > On Thu, Jun 22, 2023 at 05:53:13PM +0200, Rafael J. Wysocki wrote:
> > > On Wed, Jun 21, 2023 at 5:16 PM Andy Shevchenko
> > > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

...

> > /* Check if the device has resources provided by _CRS method */
> > #define ACPI_PLATFORM_CHECK_RES BIT(0)
> >
> > ?
>
> Could be, but this is specific to forbidden_ids_list[]. Maybe
> ACPI_ALLOW_WO_RESOURCES or similar.

Got it, will do this way.

...

> BTW, this doesn't need to increment the count even. It could just
> terminate the walk on the first valid resource found and tell the
> caller to return true in that case.

Indeed, thank you for the hint!

--
With Best Regards,
Andy Shevchenko