Re: [PATCH 08/24] init: pass root_device_name explicitly

From: Christoph Hellwig
Date: Mon Jun 26 2023 - 03:53:34 EST


On Fri, Jun 23, 2023 at 05:08:59PM -0700, Guenter Roeck wrote:
> Hi,
>
> On Wed, May 31, 2023 at 02:55:19PM +0200, Christoph Hellwig wrote:
> > Instead of declaring root_device_name as a global variable pass it as an
> > argument to the functions using it.
> >
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
>
> This patch results in the following build error when trying to build
> xtensa:tinyconfig.
>
> WARNING: modpost: vmlinux: section mismatch in reference: strcpy.isra.0+0x14 (section: .text.unlikely) -> initcall_level_names (section: .init.data)
> ERROR: modpost: Section mismatches detected.

I can reproduce these with gcc 13.1 on xtensa, but the report makes
no sense to me. If I disable CONFIG_CC_OPTIMIZE_FOR_SIZE it now reports
a similar warning for put_page intead of strcpy which seems just as
arcance.