Re: Kernel oops with netfilter: nf_tables: incorrect error path handling with NFT_MSG_NEWRULE

From: Pablo Neira Ayuso
Date: Sun Jun 25 2023 - 19:05:54 EST


Hi,

On Sun, Jun 25, 2023 at 12:38:08PM -0500, Matthias Maier wrote:
> Dear all,
>
> commit 1240eb93f0616b21c675416516ff3d74798fdc97
> aka bdace3b1a51887211d3e49417a18fdbd315a313b (linux-6.3.y)
> netfilter: nf_tables: incorrect error path handling with NFT_MSG_NEWRULE
>
> causes a kernel oops on my side when booting my machine; see attached.
>
> Reverting this commit fixes the kernel oops.
> Tested on 6.3.9 and 6.4.0-rc7

Could you give a try to these two fixes on top?

26b5a5712eb8 netfilter: nf_tables: add NFT_TRANS_PREPARE_ERROR to deal with bound set/chain
4bedf9eee016 netfilter: nf_tables: fix chain binding transaction logic

These patches are scheduled for 6.4

You might also need this one on top:

https://patchwork.ozlabs.org/project/netfilter-devel/patch/20230625224219.64876-1-pablo@xxxxxxxxxxxxx/

If problem still persists, a reproducer would be good to have.

Thanks.