Re: [PATCH] clk: imx: Drop inclusion of unused header <soc/imx/timer.h>

From: Uwe Kleine-König
Date: Sun Jun 25 2023 - 03:52:35 EST


On Fri, Jun 23, 2023 at 09:19:19AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> After removing this header in the clocksource tree, the clk drivers no
> longer build:
>
> drivers/clk/imx/clk-imx1.c:13:10: fatal error: 'soc/imx/timer.h' file not found
> drivers/clk/imx/clk-imx27.c:11:10: fatal error: 'soc/imx/timer.h' file not found
>
> This patch was originally posted as part of a three-patch series, but only
> patches 1 and 3 got applied.
>
> Reported-by: Linux Kernel Functional Testing <lkft@xxxxxxxxxx>
> Fixes: 9e9d7570485d7 ("clocksource/drivers/imx-gpt: Fold <soc/imx/timer.h> into its only user")
> Link: https://lore.kernel.org/all/20230328100531.879485-2-u.kleine-koenig@xxxxxxxxxxxxxx/
> Signed-off-by: "Uwe Kleine-König" <u.kleine-koenig@xxxxxxxxxxxxxx>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

A bit strange that this patch has author=Arnd but still my S-o-b. Either
it's "my" patch (then I'd like to have author=Uwe), or it's Arnd's then
I'm not in the submission path and my S-o-b is misleading.

The commit log of this patch is better as it mentions the fact that only
a part of my series was applied and that the 0day bot was in the loop.
So I suggest to make my Signed-off-by line a Co-developed-by one (and
drop the quotes around my name).

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature