RE: [v2 1/2] arm64: dts: agilex/stratix10: Updated QSPI Flash layout for UBIFS

From: Lee, Kah Jing
Date: Fri Jun 23 2023 - 23:31:35 EST


> -----Original Message-----
> From: Markus Elfring <Markus.Elfring@xxxxxx>
> Sent: Friday, 23 June, 2023 7:04 PM
> To: Lee, Kah Jing <kah.jing.lee@xxxxxxxxx>; Yuslaimi, Alif Zakuan
> <alif.zakuan.yuslaimi@xxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx; kernel-
> janitors@xxxxxxxxxxxxxxx; Catalin Marinas <catalin.marinas@xxxxxxx>;
> Conor Dooley <conor+dt@xxxxxxxxxx>; Dinh Nguyen <dinguyen@xxxxxxxxxx>;
> Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Will Deacon <will@xxxxxxxxxx>
> Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>; cocci@xxxxxxxx
> Subject: Re: [v2 1/2] arm64: dts: agilex/stratix10: Updated QSPI Flash layout
> for UBIFS
>
> > Updated in v3 - Commit message:
> > Update the QSPI flash layout to support UBIFS in mtd root partition.
> > Flash layout is updated in order to store non-UBIFS related boot and
> > fpga data in qspi_boot(mtd0) while keep the rootfs with UBIFS in the root
> partition(mtd1).
>
> I got the impression that this change description is also improvable a bit.
> How do you think about a wording variant like the following?
>
>
> Non-UBIFS related boot and fpga data should be stored in qspi_boot (mtd0)
> while keeping the rootfs with UBIFS in the root partition “mtd1”.
> Thus update the QSPI flash layout to support UBIFS in the mtd root partition.
>
>
> Will similar adjustments become helpful for subsequent update steps?
Sounds good to me. Will update the commit message for v3.
Thanks.
>
> Regards,
> Markus

Regards,
Lee, Kah Jing