Re: [PATCH net-next v2 07/10] net: phy: add support for C45-over-C22 transfers

From: Simon Horman
Date: Fri Jun 23 2023 - 16:46:01 EST


On Fri, Jun 23, 2023 at 12:29:16PM +0200, Michael Walle wrote:

...

> @@ -780,7 +806,8 @@ static int get_phy_c45_devs_in_pkg(struct mii_bus *bus, int addr, int dev_addr,
> * the "devices in package" is invalid.
> */
> static int get_phy_c45_ids(struct mii_bus *bus, int addr,
> - struct phy_c45_device_ids *c45_ids)
> + struct phy_c45_device_ids *c45_ids,
> + bool c45_over_c22)

Hi Michael,

Please consider adding c45_over_c22 to the kernel doc for get_phy_c45_ids,
which appears a few lines above.

...