Re: [PATCH 2/2] dt-bindings: clock: ehrpwm: Remove unneeded syscon compatible

From: Andrew Davis
Date: Fri Jun 23 2023 - 16:18:51 EST


On 6/23/23 2:59 PM, Rob Herring wrote:
On Wed, May 17, 2023 at 1:53 AM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:

On Tue, 16 May 2023 13:46:26 -0500, Andrew Davis wrote:
This node's register space is not accessed by any other node, which
is the traditional use for the "syscon" hint. It looks to have been
added here to make use of a Linux kernel helper syscon_node_to_regmap().
The Linux driver now uses a more appropriate helper that does not
require the hint, so let's remove it from the binding.

Signed-off-by: Andrew Davis <afd@xxxxxx>
---
.../devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)


My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.example.dtb: scm-conf@100000: clock-controller@4140:compatible: ['ti,am654-ehrpwm-tbclk', 'syscon'] is too long
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.example.dtb: clock-controller@4140: compatible: ['ti,am654-ehrpwm-tbclk', 'syscon'] is too long
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml

Now failing in linux-next.


Sent fix: https://lore.kernel.org/lkml/20230623201519.194269-1-afd@xxxxxx/T/#u

Andrew