Re: [PATCH 4/5] scsi: dt-bindings: ufs: qcom: Fix sm8450 clocks

From: Rob Herring
Date: Fri Jun 23 2023 - 16:12:38 EST


On Fri, Jun 23, 2023 at 06:21:24AM -0600, Rob Herring wrote:
>
> On Fri, 23 Jun 2023 14:30:08 +0300, Abel Vesa wrote:
> > The sm8450 has an ICE clock, so move the compatible to the proper
> > clocks check.
> >
> > Fixes: 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema")
> > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: clocks: [[4294967295, 151], [4294967295, 10], [4294967295, 150], [4294967295, 166], [4294967295, 0], [4294967295, 164], [4294967295, 160], [4294967295, 162]] is too short
> from schema $id: http://devicetree.org/schemas/ufs/qcom,ufs.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: clock-names: ['core_clk', 'bus_aggr_clk', 'iface_clk', 'core_clk_unipro', 'ref_clk', 'tx_lane0_sync_clk', 'rx_lane0_sync_clk', 'rx_lane1_sync_clk'] is too short
> from schema $id: http://devicetree.org/schemas/ufs/qcom,ufs.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: reg: [[0, 30949376, 0, 12288]] is too short
> from schema $id: http://devicetree.org/schemas/ufs/qcom,ufs.yaml#

Looks like patch 1 didn't apply for me and would fix this.

Rob