Re: [PATCH v2] perf unwind: Fix map reference counts

From: Namhyung Kim
Date: Fri Jun 23 2023 - 13:58:39 EST


Hello,

On Fri, Jun 23, 2023 at 10:49 AM Ian Rogers <irogers@xxxxxxxxxx> wrote:
>
> On Fri, Jun 23, 2023 at 9:18 AM Markus Elfring <Markus.Elfring@xxxxxx> wrote:
> >
> > > v2. Add missing map__put when dso is missing.
> > > ---
> >
> > Please omit such version information from the change suggestion.
> >
> > See also:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4-rc7#n698
>
> ah, tldr. Will correct in the future.

Thanks for taking a look at this. I moved it above the tag lines
this time.

>
> >
> > How do you think about to add the tag “Fixes”?
>
> In general we've not been adding Fixes as there is a danger a backport
> will introduce a use-after-free.

Right, this change depends on other changes. Simply cherry-picking
this will result in unmatched ref count IIUC.

Applied to perf-tools-next, thanks!