Re: [PATCH] libnvdimm/of_pmem: Add check and kfree for kstrdup

[Ira Weiny]

Jiasheng Jiang wrote:
> On Wed, Jun 21, 2023 at 00:04:36 +0800, Ira Weiny wrote:
> > Ira Weiny wrote:
> >> Jiasheng Jiang wrote:

[snip]

> >> 
> >> Nice catch!
> >> 
> >> However, this free needs to happen in of_pmem_region_remove() as well.
> > 
> > Looks like the mail from my phone had html in it.  Sorry for that.
> > 
> > This would be better with devm_kstrdup() and then we don't have to worry
> > about the kfree at all.
> 
> Looks good.
> I have submitted a new patch "libnvdimm/of_pmem: Replace kstrdup with devm_kstrdup and add check".
> Since the titie has been modified, I did not submitted a v2.

Ah ok...  But looks like we will need a v3.  See the other email.

Thanks again for trying to fix this,
Ira