Re: [PATCH 08/39] drm: renesas: shmobile: Use %p4cc to print fourcc code

From: Laurent Pinchart
Date: Fri Jun 23 2023 - 11:04:50 EST


Hi Geert,

Thank you for the patch.

On Thu, Jun 22, 2023 at 11:21:20AM +0200, Geert Uytterhoeven wrote:
> Replace the last printing of an hexadecimal fourcc format code by a
> pretty-printed format name, using the "%p4cc" format specifier.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>

> ---
> drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c
> index 7e49e2873da1bb6f..36fedb2b74c8b7a2 100644
> --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c
> +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c
> @@ -184,8 +184,8 @@ shmob_drm_plane_update(struct drm_plane *plane, struct drm_crtc *crtc,
>
> format = shmob_drm_format_info(fb->format->format);
> if (format == NULL) {
> - dev_dbg(sdev->dev, "update_plane: unsupported format %08x\n",
> - fb->format->format);
> + dev_dbg(sdev->dev, "update_plane: unsupported format %p4cc\n",
> + &fb->format->format);
> return -EINVAL;
> }
>

--
Regards,

Laurent Pinchart