Re: [PATCH] drm/mgag200: set variable mgag200_modeset storage-class-specifier to static

From: Jocelyn Falempe
Date: Fri Jun 23 2023 - 05:06:08 EST


On 23/06/2023 10:28, Thomas Zimmermann wrote:


Am 17.05.23 um 15:41 schrieb Tom Rix:
smatch reports
drivers/gpu/drm/mgag200/mgag200_drv.c:23:5: warning: symbol
   'mgag200_modeset' was not declared. Should it be static?

This variable is only used in its defining file, so it should be static

Signed-off-by: Tom Rix <trix@xxxxxxxxxx>

Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx>

---
  drivers/gpu/drm/mgag200/mgag200_drv.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c
index 976f0ab2006b..abddf37f0ea1 100644
--- a/drivers/gpu/drm/mgag200/mgag200_drv.c
+++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
@@ -20,7 +20,7 @@
  #include "mgag200_drv.h"
-int mgag200_modeset = -1;
+static int mgag200_modeset = -1;
  MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
  module_param_named(modeset, mgag200_modeset, int, 0400);


applied to drm-misc-next

Thanks for your contribution.

--

Jocelyn