Re: [EXT] Re: [PATCH] net: atlantic: fix ring buffer alignment

From: Jakub Kicinski
Date: Thu Jun 22 2023 - 12:37:27 EST


On Thu, 22 Jun 2023 07:49:52 +0200 Igor Russkikh wrote:
> > Agreed that the comment is confusing seems to be incorrect post-change.
> > Flags for instance are overlapped with len, is_gso etc. so they can't be
> > a separate 8B at the end.
> >
> > Igor, please advise how you want to proceed.
>
> I do agree better to remove the comment at all - it explains almost nothing.
>
> Thats not a hardware related structure, so explicit pack is for sure not required.
>
> Acked-by: Igor Russkikh <irusskikh@xxxxxxxxxxx>

Thanks Igor!
Arnd, could you respin with the comment removed?