Re: [PATCH v6 03/27] cxl: Updates for CXL Test to work with RCH

From: Terry Bowman
Date: Thu Jun 22 2023 - 10:03:11 EST


Hi Jonathan,

On 6/22/23 04:53, Jonathan Cameron wrote:
> On Wed, 21 Jun 2023 22:51:02 -0500
> Terry Bowman <terry.bowman@xxxxxxx> wrote:
>
>> From: Dan Williams <dan.j.williams@xxxxxxxxx>
>>
>> CXL test needs to be updated to work with latest RCH changes.
>> Add CXL test support for devm_cxl_add_rch_dport and
>> cxl_rcd_component_reg_phys functions.
>>
>> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
>> Signed-off-by: Terry Bowman <terry.bowman@xxxxxxx>
>> Signed-off-by: Robert Richter <rrichter@xxxxxxx>
>
> This chain is getting confusing.
>
> Why a SoB from Robert on this one?
> As Terry sent the series I'd expect Terry to be last unless there
> was some codevelopment involved in which case that should be indicated
> in the tags.
>

This was a mistake on my part. I'll remove Robert. Thanks for pointing out.

Regards,
Terry

> For weird corner cases it's worth adding some comments on why a SoB chain
> is non obvious.
>
> I'm far from an expert on cxl-test so I'll leave reviewing this in
> depth to others. FWIW looks fine to me.
>
> Jonathan
>