Re: [PATCH] drm/mgag200: Fix a warning reported by Fi.CI.SPARSE

From: Jocelyn Falempe
Date: Thu Jun 22 2023 - 08:36:55 EST


This patch was already sent by Tom Rix last month:
https://patchwork.freedesktop.org/series/117881/

I can push it to drm-misc-next, if Thomas is ok.

Best regards,

--

Jocelyn

On 21/06/2023 21:11, Sui Jingfeng wrote:
drivers/gpu/drm/mgag200/mgag200_drv.c:23:5: warning: symbol 'mgag200_modeset' was not declared. Should it be static?

Found in the log of Fi.CI.SPARSE test [1]

[1] https://patchwork.freedesktop.org/series/119249/

Signed-off-by: Sui Jingfeng <suijingfeng@xxxxxxxxxxx>
---
drivers/gpu/drm/mgag200/mgag200_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c
index 976f0ab2006b..abddf37f0ea1 100644
--- a/drivers/gpu/drm/mgag200/mgag200_drv.c
+++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
@@ -20,7 +20,7 @@
#include "mgag200_drv.h"
-int mgag200_modeset = -1;
+static int mgag200_modeset = -1;
MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
module_param_named(modeset, mgag200_modeset, int, 0400);