Re: [PATCH] vhost-vdpa: filter VIRTIO_F_RING_PACKED feature

[Stefano Garzarella]

On Thu, Jun 22, 2023 at 07:37:08AM -0400, Michael S. Tsirkin wrote:
> On Mon, Jun 05, 2023 at 01:06:44PM +0200, Stefano Garzarella wrote:
> > vhost-vdpa IOCTLs (eg. VHOST_GET_VRING_BASE, VHOST_SET_VRING_BASE)
> > don't support packed virtqueue well yet, so let's filter the
> > VIRTIO_F_RING_PACKED feature for now in vhost_vdpa_get_features().
> >
> > This way, even if the device supports it, we don't risk it being
> > negotiated, then the VMM is unable to set the vring state properly.
> >
> > Fixes: 4c8cf31885f6 ("vhost: introduce vDPA-based backend")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Stefano Garzarella <sgarzare@xxxxxxxxxx>
>
> OK so for now I dropped this, we have a better fix upstream.

Yep, I agree.

Maybe we can reuse this patch in the stable branches where the backport
is not easy. Although as Jason said, maybe we don't need it.

Thanks,
Stefano